Evaluate the layouts for the tasks at compile time #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this may obsolete #29, since the layout is now essentially already cached into each of the VTable functions |
|
Nice! Great idea to go through an associated const. Thanks for looking into it, @notgull An adapted version of #29 will still be necessary for debuggability (because So, I'd be in favor of merging this PR first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for the challenge, @michaelwoerister
This pull request adds new internal functionality to
async-taskthat, rather than computingtask_layout()at runtime, turns it into an associatedconstonRawTask. Safety guarantees are still upheld; the program will stillabort()at runtime with an invalid task layout.Note that this bumps up the MSRV to 1.47.0, as that is when the
checked_*family of functions were stabilized asconst-evalutated. @taiki-e has mentioned that they are comfortable bumping the MSRV to up to 1.48.0, so I hope this shouldn't be an issue.